Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic brand naming #9

Closed
wants to merge 1 commit into from
Closed

Dynamic brand naming #9

wants to merge 1 commit into from

Conversation

hazzuk
Copy link
Member

@hazzuk hazzuk commented Dec 11, 2024 •
edited
Loading

Replace static brand names with dynamic variables.

@github-actions GitHub Actions
Copy link

Cloudflare Pages deployment

Latest commit dbc42ca1746e4b59e8979ab7f36b15e373a5bd09
Status ✅ Deployed!
URL https://573d00e0.elecord-web.pages.dev

@hazzuk
Copy link
Member Author

hazzuk commented Dec 11, 2024

Dynamic brand names doesn't correctly, as per a comment in the index.html:

Our translations system isn't smart enough to recognize variables in the HTML, so we manually do it

image

@hazzuk hazzuk closed this Dec 11, 2024
@hazzuk hazzuk deleted the brand-naming branch December 11, 2024 11:38
@hazzuk hazzuk added the investigation Exploring possible causes and solutions label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
investigation Exploring possible causes and solutions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hazzuk