Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment geo and aggs deprecated names #119872

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jan 9, 2025

This adds comments to the deprecated names in geo and aggregations explaining that we're not removing them so we don't break any callers. Some of these have been deprecated for ten years but we're keeping them.

This adds comments to the deprecated names in geo and aggregations
explaining that we're not removing them so we don't break any callers.
Some of these have been deprecated for ten years but we're keeping them.
@nik9000 nik9000 added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/Aggregations Aggregations v9.0.0 v8.18.0 labels Jan 9, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@craigtaverner craigtaverner self-assigned this Jan 15, 2025
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I honestly think actually removing old stuff is a valuable thing to do.

@nik9000 nik9000 added the auto-backport Automatically create backport pull requests when merged label Jan 16, 2025
@nik9000 nik9000 merged commit 219e8c2 into elastic:main Jan 16, 2025
16 checks passed
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Jan 16, 2025
This adds comments to the deprecated names in geo and aggregations
explaining that we're not removing them so we don't break any callers.
Some of these have been deprecated for ten years but we're keeping them.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 16, 2025
This adds comments to the deprecated names in geo and aggregations
explaining that we're not removing them so we don't break any callers.
Some of these have been deprecated for ten years but we're keeping them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations :Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants