Callback recieves copy of buffer metadata not buffer itself (#53)

elastic · Apr 9, 2024 · 78cef91 · 78cef91
1 parent 2cdc188
commit 78cef91
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/examples/playground/Program.cs b/examples/playground/Program.cs
@@ -61,7 +61,6 @@ async Task DoChannelWrite(int i, CancellationToken cancellationToken)
 			return;
 
 		Console.WriteLine("Failed To write");
-		await Task.Delay(TimeSpan.FromSeconds(5), cancellationToken);
 	}
 }
 

diff --git a/src/Elastic.Channels/BufferedChannelBase.cs b/src/Elastic.Channels/BufferedChannelBase.cs
@@ -277,7 +277,8 @@ private async Task ExportBufferAsync(ArraySegment<TEvent> items, IOutboundBuffer
 			try
 			{
 				response = await ExportAsync(items, TokenSource.Token).ConfigureAwait(false);
-				_callbacks.ExportResponseCallback?.Invoke(response, outboundBuffer);
+				_callbacks.ExportResponseCallback?.Invoke(response,
+					new WriteTrackingBufferEventData { Count = outboundBuffer.Count, DurationSinceFirstWrite =  outboundBuffer.DurationSinceFirstWrite });
 			}
 			catch (Exception e)
 			{

diff --git a/src/Elastic.Channels/Buffers/IWriteTrackingBuffer.cs b/src/Elastic.Channels/Buffers/IWriteTrackingBuffer.cs
@@ -19,3 +19,9 @@ public interface IWriteTrackingBuffer
 	/// </summary>
 	TimeSpan? DurationSinceFirstWrite { get; }
 }
+
+internal class WriteTrackingBufferEventData : IWriteTrackingBuffer
+{
+	public int Count { get; set; }
+	public TimeSpan? DurationSinceFirstWrite { get; set; }
+}
-Original file line number
+Diff line change
@@ Expand Up @@
     			return;
     		Console.WriteLine("Failed To write");
-    		await Task.Delay(TimeSpan.FromSeconds(5), cancellationToken);
     	}
     }
@@ Expand Down @@