Add preview workflow #279
Open
Add preview workflow #279
+200
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Jan 21, 2025
.github/workflows/preview.yml
Outdated
| # we run our artifact directly please use the prebuild | ||
| # elastic/docs-builder@main GitHub Action for all other repositories! | ||
| - name: Build documentation | ||
| run: .artifacts/publish/docs-builder/release/docs-builder --strict |
There was a problem hiding this comment.
Should we cache this from the pr.yml build and then move the general docs build as part of this workflow ?
In other words we make this depend on the pr workflow.
Mpdreamz
reviewed
Jan 21, 2025
.github/workflows/preview.yml
Outdated
| # elastic/docs-builder@main GitHub Action for all other repositories! | ||
| - name: Build documentation | ||
| run: .artifacts/publish/docs-builder/release/docs-builder --strict | ||
| - name: Generate AWS Role ARN |
There was a problem hiding this comment.
I think we also want to extend our publish github action to include this.
Mpdreamz
reviewed
Jan 21, 2025
bmorelli25
reviewed
Jan 22, 2025
reakaleek
force-pushed
the
feature/preview-build
branch
from
9657bdb to
c0a2f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.