-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks: clean up infra logs #15198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response from curl could contain secrets for the test ephimeral cluster. There is no need to display it unless an error occurred, when we may need it for debugging purposes.
This pull request does not have a backport label. Could you fix it @endorama? 🙏
|
|
mergify
bot
added
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Jan 9, 2025
v1v
approved these changes
Jan 9, 2025
rubvs
approved these changes
Jan 9, 2025
1pkg
approved these changes
Jan 10, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
The response from curl could contain secrets for the test ephimeral cluster. There is no need to display it unless an error occurred, when we may need it for debugging purposes. (cherry picked from commit 1261584)
mergify bot
added a commit
that referenced
this pull request
Jan 10, 2025
The response from curl could contain secrets for the test ephimeral cluster. There is no need to display it unless an error occurred, when we may need it for debugging purposes. (cherry picked from commit 1261584) Co-authored-by: Edoardo Tenani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Clean up
benchmarks
GitHub Actions workflow to reduce logging fromcurl
used to setup the ephimeral test clusters.Checklist
How to test these changes
Related issues