refactor: optimize compile speed (skip fetch deps) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- till now, we used Stdlib from the `move` repo:
```
MoveStdlib = { git = "https://github.com/move-language/move.git", subdir = "language/move-stdlib", rev = "main" }
```
- the right approach is to use aptos stdlib:
```
[dependencies.AptosStdlib]
git = 'https://github.com/aptos-labs/aptos-core.git'
rev = 'main'
subdir = 'aptos-move/framework/aptos-stdlib'
```
Rqnsom
force-pushed
the
develop/refactor/speed-up-the-compilation-with-skip-fetch-latest-deps-flag
branch
2 times, most recently
from
601f5f3 to
03f7dea
Compare
Optimization takes use of the `skip-fetch-latest-git-deps` compilation flag. Regardless of this flag, by default - if no deps are found in the `/Users/$USER/.move` directory (a cache folder for Move packages) the missing packages will be downloaded there. But if the cache exists, then the `skip-fetch-latest-git-deps` flag can be used to skip checking whether those cached Move packages ought to be updated. In this PR - for the first compilation step (checking that the original tests are working fine), we disable that flag and ensure we get the latest Move packages. Then, for all subsequent compilations (mutant generation and running tests on those mutants), the tool enables that flag since it doesn't make much sense to check the latest deps repeatedly - checking it only once when the tool is started - it should be good enough.
Rqnsom
force-pushed
the
develop/refactor/speed-up-the-compilation-with-skip-fetch-latest-deps-flag
branch
from
03f7dea to
1017643
Compare
asmie
approved these changes
Sep 12, 2024
Rqnsom
deleted the
develop/refactor/speed-up-the-compilation-with-skip-fetch-latest-deps-flag
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization takes use of the
skip-fetch-latest-git-depscompilation flag.Regardless of this flag, by default - if no deps are found in the
/Users/$USER/.movedirectory (a cache folder for Move packages)the missing packages will be downloaded there.
But if the cache exists, then the
skip-fetch-latest-git-depsflag canbe used to skip checking whether those cached Move packages ought to be
updated.
In this PR - for the first compilation step (checking that the original
tests are working fine), we disable that flag and ensure we get the
latest Move packages.
Then, for all subsequent compilations (mutant generation and running
tests on those mutants), the tool enables that flag since it doesn't
make much sense to check the latest deps repeatedly - checking it only
once when the tool is started, it should be good enough.
Note: there is a x5 compilation speed increase here.
Additional PR is included here:
chore: switch to aptos stdlib in tests
moverepo: