BUGFIX/HCMPRE-1584: Disable planSearch for popInbox and CSS for dropdown

[abishekTa-egov]

BUGFIX/HCMPRE-1584: Disable planSearch for popInbox and CSS for dropdown

Summary by CodeRabbit

• New Features

  • Added tooltips to facility-related dropdown menus
  • Enhanced dropdown configuration with dynamic API hook enabling

• Bug Fixes

  • Corrected error variable naming for consistency

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request focuses on modifying the InboxFilterWrapper.js component in the microplan module. The changes involve dynamically configuring the planFacilitySearchConfig based on the isPlanInbox prop and adding tooltip functionality to dropdown components. The modifications improve the conditional rendering of facility search configurations and enhance the user interface by providing additional interaction hints through tooltips, while also ensuring consistent naming for error handling.

Changes

File	Change Summary
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js	- Renamed planFacilityerror to planFacilityError - Updated planFacilitySearchConfig.config.enabled to use props?.isPlanInbox - Added showToolTip={true} to Dropdown components for onRoadCondition, terrain, facilityId, and security questions

Possibly related PRs

• FEATURE/HCMPRE-1712: Facility Dropdown for plan Inbox #2096: Modifies InboxFilterWrapper.js, adding facility dropdown and enhancing planFacilitySearchConfig.
• FEATURE/HCMPRE-1713: PopInbox and filtering integration #2108: Updates InboxFilterWrapper.js, improving state management and dropdown rendering logic.

Suggested reviewers

• nipunarora-eGov
• Swathi-eGov

Poem

🐰 Dropdowns dance with tooltips bright,
Configs shift with conditional might,
Errors renamed, code now clean and tight,
In the realm of microplans, we take flight!
A rabbit's code review, pure delight! 🔍

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bff091f and a85ec75.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (6 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Learnt from: Ramkrishna-egov
PR: egovernments/DIGIT-Frontend#1562
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js:57-57
Timestamp: 2024-11-12T10:40:17.779Z
Learning: In the `InboxFilterWrapper` component, `optionsKey` should always be set to `"name"` because options are transformed and created within the component.

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (2)

129-129: LGTM! Improved variable naming convention.

Good cleanup - the renamed error variable now follows proper camelCase convention.

---

177-177: Inconsistent optionsKey usage.

Based on previous learnings, optionsKey should be set to "name" as options are transformed within the component. However, the dropdowns are using "code".

Could you confirm if this is intentional or if it should be aligned with the previous guidance?

Also applies to: 190-190, 203-203

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a85ec75 and a624ffa.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (6 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Learnt from: Ramkrishna-egov
PR: egovernments/DIGIT-Frontend#1562
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js:57-57
Timestamp: 2024-11-12T10:40:17.779Z
Learning: In the `InboxFilterWrapper` component, `optionsKey` should always be set to `"name"` because options are transformed and created within the component.

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (2)

129-131: Consider improving error handling.

The API error is captured but not handled. Consider adding error feedback for users when facility data fails to load.

---

177-177: Consider extracting common Dropdown props to reduce repetition.

While adding tooltips improves the UI, the implementation is repetitive. Consider creating a base configuration object for common Dropdown props.