FEATURE/HCMPRE-1704 : Removing current validation from assumptions an…

[Swathi-eGov]

…d making sure the flow works as expected( for mixed strat, regis and dist can be same)

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved form validation for registration and distribution process selection by refining error conditions.

• New Features

  • Added loading state for boundary status map updates, providing user feedback during loading.
  • Enhanced dropdown option handling in the assumptions form to display all available options without filtering.

The changes focus on improving user experience and form validation in the microplan module, with more robust handling of process selections and loading states.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces changes to three files in the microplan module of a health application. The modifications focus on the removal of a filtering mechanism for dropdown options in the AssumptionsForm, the addition of a loading state in the BoundarySelection, and a refinement of the validation logic in the utilities.js. These changes enhance the user interface and validation processes, particularly in handling the "MIXED" strategy code.

Changes

File	Change Summary
health/micro-ui/.../AssumptionsForm.js	Removed filtering mechanism for dropdown options based on resourceDistributionStrategyCode. Now all options are displayed regardless of the strategy code.
health/micro-ui/.../BoundarySelection.js	Added isStatusMapLoading state to manage loading feedback during status map creation. Conditionally renders a loader based on the loading state.
health/micro-ui/.../utilities.js	Modified assumptionsFormValidator to prevent error message when registration and distribution process codes are the same and set to "MIXED".

Possibly related PRs

• FEATURE/HCMPRE-1713: PopInbox and filtering integration #2108: The changes in the InboxFilterWrapper.js component involve modifications to the dropdown options and state management, which are relevant to the dropdown functionality altered in the AssumptionsForm.js file of the main PR.

Suggested reviewers

• nipunarora-eGov

Poem

🐰 Hopping through code with glee,
Dropdowns dance, validation free!
Loading states, a rabbit's delight,
Microplan's changes shine so bright!
Filters gone, options unfurled! 🌈

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 5

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50641c7 and ba7393c.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/AssumptionsForm.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/AssumptionsForm.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

21-21: LGTM! Well-named state variable for loading management.

The new state variable follows React conventions and clearly indicates its purpose.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/AssumptionsForm.js (1)

102-105: LGTM! The registration process dropdown implementation looks good.

The direct mapping of options without filtering aligns well with the updated validation logic.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

107-107: 🧹 Nitpick (assertive)

Consider preventing layout shifts during loading.

The conditional rendering between Loader and BoundaryKpi might cause layout shifts. Consider wrapping both components in a container with fixed dimensions to maintain layout stability during loading states.

-      {isStatusMapLoading ? <Loader /> : <BoundaryKpi data={statusMap} />}
+      <div className="boundary-kpi-container">
+        {isStatusMapLoading ? <Loader /> : <BoundaryKpi data={statusMap} />}
+      </div>

Add the following CSS to your stylesheet:

.boundary-kpi-container {
  min-height: 200px; /* Adjust based on your BoundaryKpi component's typical height */
  position: relative;
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba7393c and 0627954.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

21-21: LGTM! Loading state initialization is well-placed.

The loading state is correctly initialized with other state declarations.