Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produceasync #1192

Merged
merged 15 commits into from
Jul 31, 2024
Merged

Produceasync #1192

merged 15 commits into from
Jul 31, 2024

Conversation

ashish-egov
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Warning

Rate limit exceeded

@ashish-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 26 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 59ec953 and 562952d.

Walkthrough

Walkthrough

The recent changes enhance the asynchronous handling and control flow across multiple utility files in the project. The introduction of the await keyword in various functions ensures that operations are executed in the correct order, improving reliability and reducing potential race conditions. These adjustments promote better error management and overall robustness of the application, particularly in processes related to campaigns and Kafka messaging.

Changes

Files Change Summary
.../campaignApis.ts Enhanced control flow with proper asynchronous handling in processValidate, handleResouceDetailsError, and processCreate.
.../kafka/Producer.ts Updated Kafka producer availability check to use loadMetadataForTopics, improved logging, and added event listeners for better error handling.
.../utils/campaignMappingUtils.ts Altered processMapping function to await produceModifiedMessages, ensuring proper message production timing.
.../utils/campaignUtils.ts Added await for produceModifiedMessages and createProcessTracks in several functions, improving control flow and data integrity in campaign processing.
.../utils/genericUtils.ts Introduced await in multiple async calls, improved error handling by making handleGenerateError an async function, ensuring timely execution of operations.
.../utils/processTrackUtils.ts Made several functions asynchronous to allow for await, ensuring proper sequence of operations and robust error handling in process tracking.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Kafka
    User->>App: Start campaign process
    App->>Kafka: Check broker availability
    Kafka-->>App: Broker available
    App->>App: Process campaign data
    App->>Kafka: Produce message
    Kafka-->>App: Message produced successfully
    App->>User: Campaign process completed
Loading

Poem

🐇 In the meadow where we play,
Changes came to light today.
With a hop and a skip, we found,
Asynchronous joy all around!
Messages dance, errors take flight,
Our coding world shines so bright! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagankumar-egov jagankumar-egov merged commit 7212232 into campaign Jul 31, 2024
3 of 4 checks passed
@jagankumar-egov jagankumar-egov deleted the produceasync branch July 31, 2024 09:12
Bhavya-egov pushed a commit that referenced this pull request Aug 12, 2024
* Update Listener.ts

* added new branch

* Update Listener.ts

* fixed mapping kafka error

* mapping kafka fixed

* fix kafka

* fix kafka

* Producer update

* Feat : updated producemodified message

* Update publishProjectFactory.yml

* Update publishProjectFactory.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants