fix: use django utils timezone to make timezone aware #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
varshamenon4
commented
Jan 8, 2025
MichaelRoytman
approved these changes
Jan 8, 2025
varshamenon4
force-pushed
the
varshamenon4/fix-use-timezone-now-aware-datetime
branch
from
6bf5de9 to
0ecc81e
Compare
varshamenon4
deleted the
varshamenon4/fix-use-timezone-now-aware-datetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which caused an error in audit_trial_is_expired which was happening due to an incompatible comparison in timezone naive and aware datetimes.
Instead of using datetime.now(), we now use timezone.now() from Django utils which makes timezone aware / naive based on the USE_TZ setting. This changes both the instance of this in audit_trial_is_expired and also in the LearningAssistantAuditTrialData's start_date and expiration_date.
This ensures consistency in the comparisons.