Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(olmo): add css support and cdn compatibility #3

Merged
merged 5 commits into from
Dec 15, 2023
Merged

feat(olmo): add css support and cdn compatibility #3

merged 5 commits into from
Dec 15, 2023

Conversation

dcoa
Copy link
Collaborator

@dcoa dcoa commented Dec 1, 2023

@dcoa dcoa changed the title feat: add css support and cdn compatibility feat(olmo): add css support and cdn compatibility Dec 1, 2023
@dcoa dcoa force-pushed the dcoa/css-cdn-support-olmo branch from d4fe15d to be67253 Compare December 3, 2023 22:27
@dcoa dcoa force-pushed the dcoa/css-cdn-support-olmo branch from b762101 to 3ed42e5 Compare December 3, 2023 23:16
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ednx-release/olmo.master@728154a). Click here to learn what that means.

Additional details and impacted files 
@@                     Coverage Diff                     @@
##             ednx-release/olmo.master       #3   +/-   ##
===========================================================
  Coverage                            ?   81.23%           
===========================================================
  Files                               ?       86           
  Lines                               ?     1871           
  Branches                            ?      540           
===========================================================
  Hits                                ?     1520           
  Misses                              ?      336           
  Partials                            ?       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaferMazu
MaferMazu approved these changes Dec 13, 2023
View reviewed changes
Copy link

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works as expected.

@dcoa dcoa merged commit 1ad4eef into ednx-release/olmo.master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bra-i-am bra-i-am bra-i-am approved these changes

@MaferMazu MaferMazu MaferMazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcoa @codecov-commenter @MaferMazu @bra-i-am