Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for optional counter types for ordered list #129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jscastanos
Copy link

The current version has a fixed list of counter types, which are the default options for ordered list.

So this PR allows an optional way to specify a list on what counter types should be visible.

Example

 tools: {
        List: {
          class: List,
          config: {
             counterTypes: ['numeric', 'upper-roman']
          }
        },
      },

image

Closes #128

Copy link
Contributor

@e11sy e11sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems, that user could specify empty array (or array with one value) for counterTypes, then Counter type option should not be displayed in tool settings (since it would never be a choice)

you can add this changes and then it would be ready to merge, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Customizable start number and Customizable counter type
2 participants