Add support for protocol v3 and add QuerySQL and ExecuteSQL client methods
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoor
approved these changes
Jan 2, 2025
internal/client/client_test.go
Outdated
Comment on lines
202
to
203
| // err = client.ExecuteSQL(ctx, "select 1") | ||
| // assert.NoError(t, err) |
There was a problem hiding this comment.
No, good catch. I commented it out because it was failing, with the intention to go back and fix before I pushed the branch, but it seems I forgot. It looks like it's failing due to a server bug: edgedb/edgedb#8185, where the server is returning an unexpected type descriptor for executeSQL queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JS implementation: edgedb/edgedb-js#1131, and python: https://github.com/edgedb/edgedb-python/pull/534/files