Add edgeql to go code generator #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is cc @1st1 @colinhacks |
|
|
|
Ready for review |
|
@divan and anyone else that would like, we would love to have early feedback from the community on this feature if you are interested in trying it out. |
|
Currently all generated query functions are public. I think they should be private by default. Then if people ask for it we can provide a mechanism to tell the generator to make query functions public on a per query basis. |
fantix
reviewed
Oct 6, 2022
fantix
approved these changes
Oct 6, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the default behavior outlined in edgedb/edgedb#4244. All arguments and options to the generator command are left for future work along with query hashing.
The documentation, help text, and
cmd/edgeql-go/testdatadirectory may be areas of interest for reviewers.This is related to #182