Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix jq to handle missing metadata #1432

Merged
merged 1 commit into from
Dec 17, 2024
Merged

CI: Fix jq to handle missing metadata #1432

merged 1 commit into from
Dec 17, 2024

Conversation

fantix
Copy link
Member

@fantix fantix commented Dec 17, 2024

Sample JSON losing metadata:

{
  "basename": "edgedb-cli",
  "name": "edgedb-cli",
  "slot": null,
  "version": "6.1.0-dev.1225+a647d8a",
  "version_details": {
    "major": 6,
    "minor": null,
    "patch": 0,
    "prerelease": [
      {
        "phase": "dev",
        "number": 1225
      }
    ],
    "metadata": {}
  },
  "version_key": "6~dev.1225.202412070027nightly.el9",
  "revision": "202412070027nightly.el9",
  "build_date": "1970-01-01T00:00:00+00:00",
  "tags": {},
  "architecture": "aarch64",
  "installref": "edgedb-cli-6.1.0_dev.1225+a647d8a-202412070027nightly.el9.aarch64",
  "installrefs": [
    {
      "ref": "edgedb-cli-6.1.0_dev.1225+a647d8a-202412070027nightly.el9.aarch64",
      "type": null,
      "encoding": null,
      "verification": {}
    }
  ]
}

@fantix fantix requested review from msullivan and elprans December 17, 2024 14:42
@fantix fantix changed the title Fix jq to handle missing metadata CI: Fix jq to handle missing metadata Dec 17, 2024
@msullivan
Copy link
Member

msullivan commented Dec 17, 2024

Do we have any idea why the json was missing the metadata?

@fantix
Copy link
Member Author

fantix commented Dec 17, 2024

I traced up to https://github.com/edgedb/edgedb-pkg/blob/337eef62f7686750c1bd620705836eb31d0ee2ae/server/process_incoming.py#L1301-L1310 and found myself not knowing enough about the rpm repository stuff.

@fantix fantix merged commit 2a8e1b8 into master Dec 17, 2024
88 checks passed
@fantix fantix deleted the nightly branch December 17, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants