This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
timeout #484
Merged
timeout #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mak <[email protected]>
|
@sishida Could you review this? |
sishida
suggested changes
Mar 12, 2020
| --> | ||
| ## Open Liberty projects do not start within the default timeout | ||
|
|
||
| Occasionally, Appsody open liberty projects do not start and you see the following entries in the `appsody.log`: |
There was a problem hiding this comment.
- Capitalize "Open Liberty"
- Add a comma after "start"
| [Container] [INFO] CWWKM2011E: Timed out searching for CWWKF0011I: in /opt/ol/wlp/usr/servers/defaultServer/logs/messages.log. | ||
| ``` | ||
|
|
||
| By default, Open liberty projects are configured to wait 2 minutes (120 seconds) for the server to start up. The messages above is an indication that the server did not start up within the default timeout period. |
There was a problem hiding this comment.
- Capitalize "Liberty"
- Remove both instances of the word "up." The word "up" is likely to be flagged by our accessibility checking tool.
- Remove extra space before "The messages"
- Remove "above" and instead say, "These messages are an...". Directional words are an accessibility concern. (Someone with a screen reader might not be able to easily discern where "above" is.)
|
|
||
| **Workaround** | ||
|
|
||
| You can increase the timeout value in the project's `pom.xml` file. Look for the element below and increase the value: |
There was a problem hiding this comment.
- Remove "You can" and just go with the imperative "Increase the timeout..."
- Remove extra space in front of "Look"
- Say "the following element" instead of "below". This is another directional word and another accessibility concern.
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
Signed-off-by: Andrew Mak <[email protected]>
sishida
approved these changes
Mar 12, 2020
Signed-off-by: Andrew Mak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Mak [email protected]
For eclipse-archived/codewind#2455