Skip to content

Commit

Permalink
More fixes suggested by codacy
Browse files Browse the repository at this point in the history
  • Loading branch information
ecederstrand committed Dec 5, 2019
1 parent afd5dea commit e77135d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions .codacy.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
exclude_paths:
- tests/**
- scripts/**
5 changes: 2 additions & 3 deletions exchangelib/services/get_attachment.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ def _update_api_version(self, hint, api_version, header, **parse_opts):
if not parse_opts.get('stream_file_content', False):
return super(GetAttachment, self)._update_api_version(hint, api_version, header, **parse_opts)

# TODO: We're skipping this part because our streaming parser cannot parse the SOAP header
pass
# TODO: We're skipping this part in streaming mode because our streaming parser cannot parse the SOAP header

@classmethod
def _get_soap_parts(cls, response, **parse_opts):
Expand Down Expand Up @@ -68,7 +67,7 @@ def stream_file_content(self, attachment_id):
# Let the non-streaming SOAP parser parse the response and hook into the normal exception handling.
# Wrap in DummyResponse because _get_soap_payload() expects an iter_content() method.
response = DummyResponse(url=None, headers=None, request_headers=None, content=enf.data)
header, body = super(GetAttachment, self)._get_soap_parts(response=response)
_, body = super(GetAttachment, self)._get_soap_parts(response=response)
res = super(GetAttachment, self)._get_soap_messages(body=body)
for e in self._get_elements_in_response(response=res):
if isinstance(e, Exception):
Expand Down

0 comments on commit e77135d

Please sign in to comment.