Gifts index #10
Merged
Gifts index #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeLeites
reviewed
Jul 2, 2024
.rubocop.yml
Outdated
| @@ -7,6 +7,7 @@ AllCops: | |||
| - "node_modules/**/*" | |||
| - "db/schema.rb" | |||
| - "vendor/bundle/**/*" | |||
| - "db/migrate/20240621174351_create_active_storage_tables.active_storage.rb" | |||
There was a problem hiding this comment.
If you are going to ignore it, ignore all of the migrations folder
JorgeLeites
reviewed
Jul 2, 2024
app/controllers/gifts_controller.rb
Outdated
Comment on lines
2
to
3
| before_action :classes_filter, :load_filters_and_categories, only: [:index] | ||
| def index |
There was a problem hiding this comment.
Let's add a line break between before actions and methods
JorgeLeites
reviewed
Jul 3, 2024
app/models/gift.rb
Outdated
Comment on lines
8
to
13
| scope :get_gifts_from_categories, lambda { |categories, order| | ||
| with_attached_image.includes(:supplier) | ||
| .joins(:gift_categorizations) | ||
| .where(gift_categorizations: { category_id: categories }) | ||
| .order(order).distinct | ||
| } |
There was a problem hiding this comment.
This is a weird scope for the following reasons:
- The name should be something like
with_categories, so that we can read it likeGift.with_categories(ids) - It does too many things: it should only do what the name says, join it with categories and filter by category id. Let's remove the includes and the
with_attached_imagescope. Remember that you can chain scopes, so we can do
Gift.with_categories(ids).with_attached_image.includes(:supplier).order(order).distinct
JorgeLeites
reviewed
Jul 3, 2024
app/controllers/gifts_controller.rb
Outdated
| selected_categories | ||
| end | ||
| query = Gift.get_gifts_from_categories(query_categories, selected_order) | ||
| @query_count = query.count |
There was a problem hiding this comment.
The name is weid. Maybe gifts_count?
JorgeLeites
reviewed
Jul 3, 2024
Comment on lines
7
to
18
| connect(){ | ||
| if (this.checkBoxTarget.checked) { | ||
| this.labelTarget.classList.add(this.backgroundClass) | ||
| this.labelTarget.classList.add(this.textClass) | ||
| } | ||
| } | ||
| check() { | ||
| if (this.checkBoxTarget.checked) { | ||
| this.labelTarget.classList.add(this.backgroundClass) | ||
| this.labelTarget.classList.add(this.textClass) | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's add some space in between methods
JorgeLeites
reviewed
Jul 3, 2024
Comment on lines
5
to
6
| static targets = [ "checkBox", "label" ] | ||
| static classes = [ "background", 'text' ] |
There was a problem hiding this comment.
Use single qoutes for strings: https://github.com/airbnb/javascript?tab=readme-ov-file#strings--quotes
JorgeLeites
reviewed
Jul 3, 2024
|
|
||
| // Connects to data-controller="style-labels" | ||
| export default class extends Controller { | ||
| static targets = [ "checkBox", "label" ] |
There was a problem hiding this comment.
Remove spaces in brackets: https://github.com/airbnb/javascript?tab=readme-ov-file#whitespace--in-brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completed gifts index page