Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django from 5.1.1 to 5.1.2 #2304

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2024

Bumps django from 5.1.1 to 5.1.2.

Commits
  • c499184 [5.1.x] Bumped version for 5.1.2 release.
  • 6e07a77 [5.1.x] Added release date for 5.1.2.
  • 17fa759 [5.1.x] Fixed #35809 -- Set background color for selected rows in the admin's...
  • e245f62 [5.1.x] Updated translations from Transifex.
  • 6bedb10 [5.1.x] Reindented attributes and methods for classes in docs/ref/middleware....
  • bf64ac3 [5.1.x] Fixed #35670 -- Clarified the return value for LoginRequiredMiddlewar...
  • 5303113 [5.1.x] Relocated path() explanation to docs/ref/urls.txt to simplify tutoria...
  • 22bce64 [5.1.x] Fixed #35734 -- Used JSONB_BUILD_OBJECT database function on PostgreS...
  • 9e146b2 [5.1.x] Made cosmetic edits to the Steering council docs.
  • 251180f [5.1.x] Removed setting the release schedule from Steering Council prerogativ...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [django](https://github.com/django/django) from 5.1.1 to 5.1.2.
- [Commits](django/django@5.1.1...5.1.2)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the [T] Dependencies Used by Dependabot label Oct 13, 2024
@richardebeling
Copy link
Member

I don't think .lock-only updates without security relevance like this (and #2301) are helpful. We explicitly opted to use "~5.1.0" to not have a dependabot PR for every patch version upgrade. A quick google search didn't bring up an intuitive way to tell dependabot to only do this on security-relevant updates though.

@Kakadus
Copy link
Collaborator

Kakadus commented Oct 13, 2024

hm.... renovate has lockfile-maintenance, which is optional. It seems as if dependabot does this by default and has no config...

@Kakadus
Copy link
Collaborator

Kakadus commented Oct 13, 2024

In the example above, it was because the user had the increase-if-necessary versioning strategy enabled, which avoids updating package.json unless necessary. So in that PR, only the lockfile was updated. If you never want PRs that only update the lockfile, you should use the increase strategy, so you also get the package.json file updated.

Originally posted by deivid-rodriguez in https://redirect.github.com/dependabot/dependabot-core/issues/436#issuecomment-1277793723

but I fear that raising the increase strategy then does something like >=5.1.2,<5.2.0

@richardebeling
Copy link
Member

I understand this option to just answer "What should I do with the version in pyproject.toml?":

  • Default / increase: Django = "~5.1.0" is "increased" to Django = "~5.1.2" in pyproject.toml and the lock file is updated to 5.1.2.
  • increase-if-necessary: since 5.1.2 is covered by Django = "~5.1.0", pyproject.toml is not changed, but the lockfile is still updated (which is what this PR is).

Both are not what I want, I want dependabot to not change the lockfile if there is no security reason to do so, so we do not get spammed by meaningless pull requests.

(If there is an update that is relevant for security or we manually trigger an update to fix some bug, I'd want to lift the version in both files)

@niklasmohrin
Copy link
Member

From the quoted comment, it seems that dependabot's UX vision is somewhat different from our understanding of what it should do :D

I agree that lockfile-only PRs are a no-no unless there is a security fix

Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #2307 for the dependabot discussion

@dependabot squash and merge

@dependabot dependabot bot merged commit 1254590 into main Oct 14, 2024
10 checks passed
@dependabot dependabot bot deleted the dependabot/pip/django-5.1.2 branch October 14, 2024 18:22
jooooosef pushed a commit to jooooosef/EvaP that referenced this pull request Dec 16, 2024
Kakadus pushed a commit to Kakadus/EvaP that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[T] Dependencies Used by Dependabot
Development

Successfully merging this pull request may close these issues.

3 participants