Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the aarch64_simd test #241

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix the aarch64_simd test #241

merged 1 commit into from
Jan 13, 2025

Conversation

hainest
Copy link
Contributor

@hainest hainest commented Jan 9, 2025

The const_cast was causing errors on some systems. This is likely because the compiler was putting the local variable, 'buffer', in .rodata.

@hainest hainest requested a review from kupsch January 9, 2025 21:12
@hainest hainest self-assigned this Jan 9, 2025
@hainest
Copy link
Contributor Author

hainest commented Jan 11, 2025

This was inadvertently merged with #242.

@hainest hainest closed this Jan 11, 2025
@hainest hainest deleted the thaines/aarch64_simd branch January 11, 2025 13:23
@hainest hainest restored the thaines/aarch64_simd branch January 13, 2025 17:13
@hainest hainest reopened this Jan 13, 2025
The const_cast was causing errors on some systems. This is likely
because the compiler was putting the local variable, 'buffer', in
.rodata.
@hainest hainest force-pushed the thaines/aarch64_simd branch from 35bf9c6 to 0062770 Compare January 13, 2025 17:28
@hainest hainest merged commit 40c2f02 into master Jan 13, 2025
1 check passed
@hainest hainest deleted the thaines/aarch64_simd branch January 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants