wayland: Support xdg-shell as a fallback #1433
Open
+475
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the xdg-shell client protocol to the one included in wayland-protocols 1.39 . This prevent the following error when using the xdg-shell protocol: interface 'xdg_toplevel' has no event 3 It was updated using the relevant wayland-scanner commands from the wayland-protocols make target in a Debian Buster container against the xdg-shell.xml file included in version 1.39.
pslldq
force-pushed
the
supportxdgshell
branch
3 times, most recently
from
0aed2b0 to
a1bae20
Compare
Support the xdg-shell wayland protocol as a fallback in case the wlr-layer-shell-unstable-v1 protocol is not present. This allows running dunst on wayland compositors not supporting the layer shell protocol. Note that the xdg-shell protocol doesn't allow dunst to specify where it should be displayed on the screen. Therefore it is only chosen, when the layer-shell protocol is not available.
pslldq
force-pushed
the
supportxdgshell
branch
from
a1bae20 to
e293572
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
- Coverage 65.32% 64.57% -0.75%
==========================================
Files 50 51 +1
Lines 8763 8864 +101
Branches 1034 1046 +12
==========================================
Hits 5724 5724
- Misses 3039 3140 +101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the xdg-shell wayland protocol as a fallback in case the wlr-layer-shell-unstable-v1 protocol is not present. This allows running dunst on wayland compositors not supporting the layer shell protocol.
Note that the xdg-shell protocol doesn't allow dunst to specify where it should be displayed on the screen. Therefore it is only chosen, when the layer-shell protocol is not available.
Currently this allows dunst to also run on the Gnome shell (using a different session D-Bus) and weston.