Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gboolean/bool mixup #1423

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix gboolean/bool mixup #1423

merged 1 commit into from
Dec 27, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented Dec 26, 2024

Followup to #1422.
Fixes #1421.

@dcermak could you try this on s390x?
This should be a general solution for all the values

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.17%. Comparing base (381fd98) to head (13bff8a).

Files with missing lines Patch % Lines
src/dbus.c 28.57% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
+ Coverage   65.14%   65.17%   +0.03%     
==========================================
  Files          50       50              
  Lines        8718     8723       +5     
  Branches     1034     1034              
==========================================
+ Hits         5679     5685       +6     
+ Misses       3039     3038       -1     
Flag Coverage Δ
unittests 65.17% <58.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit 63e6e88 into dunst-project:master Dec 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_dbus_cb_dunst_RuleList fails on s390x
2 participants