Fix OpenBSD support and clean code #1372
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here I'm making a few small changes to help maintain support for OpenBSD.
First, OpenBSD doesn't support
wordexp.h
, so the new version ofstring_to_path
insrc/utils.c
prevents us from compiling. A condition in processing doesn't help to avoid this situation.As for the rest, I've made a minor change in
config.mk
, to give better default support to GNU Make (detecting the OS and adjusting the corresponding flags) and some changes to prevent clang/gcc from crying for-Wformat
errors.I'll be waiting for any notes or suggestions.