-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portability fixes #1288
Portability fixes #1288
Conversation
POSIX only defines '!'.
It doesn't exist e.g. on NetBSD.
Related to #1171. For the features.h it seems like it is used just to check Similarly for the button codes, I think we can remove the reliance on linux codes and just define an enum. (since they are arbitrary number anyway and are not used nowhere else) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 48 48
Lines 7920 7920
=======================================
Hits 5106 5106
Misses 2814 2814
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What operating systems are you trying to port to? That would be good to know. |
pkgsrc is cross-platform. |
I resolved a conflict with #1290. |
These patches are from pkgsrc and increase portability of dunst to other operating systems.