Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corners patch 2 #1268

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Corners patch 2 #1268

merged 7 commits into from
Feb 29, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented Jan 25, 2024

This is the 2* part of #1227.

Before we added the scaffolding for custom corners and fixed their behavior.
With this patch we add the ability to customize which corners to round trough the options:
corners, progress_bar_corners and icon_corners

Along with these options I updated the documentation, dunstrc and added a couple tests.

@bynect
Copy link
Member Author

bynect commented Jan 25, 2024

it seems like the string parsing causes problem with valgrind...

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ed5bcb4) 64.53% compared to head (275ed1b) 64.86%.

Files Patch % Lines
src/draw.c 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   64.53%   64.86%   +0.32%     
==========================================
  Files          48       48              
  Lines        7914     7954      +40     
==========================================
+ Hits         5107     5159      +52     
+ Misses       2807     2795      -12     
Flag Coverage Δ
unittests 64.86% <89.36%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect
Copy link
Member Author

bynect commented Jan 25, 2024

@fwsmit ready for me 👍🏻

@bynect bynect merged commit 4cbcc7f into dunst-project:master Feb 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants