Add IceCreamSwap trades on Boba network #7440
Merged
+130
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Hosuke
commented
Jan 8, 2025
Hosuke
commented
- Add IceCreamSwap DEX trades implementation using uniswap_compatible_v2_trades macro
- Add Boba network to dex_trades and dex_base_trades
- Add source definition for IceCreamSwap events
- Add IceCreamSwap DEX trades implementation using uniswap_compatible_v2_trades macro - Add Boba network to dex_trades and dex_base_trades - Add source definition for IceCreamSwap events
github-actions
bot
added
WIP
- Add IceCreamSwap to dex_info table - Add boba network to expose_spells
- Add seed data for IceCreamSwap on Boba network - Add schema configuration for the new seed
github-actions
bot
added
ready-for-review
Hosuke
commented
Jan 8, 2025
| }} | ||
|
|
||
| {% set base_models = [ | ||
| ref('icecreamswap_boba_base_trades') |
There was a problem hiding this comment.
jeff-dude
approved these changes
Jan 8, 2025
jeff-dude
added
ready-for-merging
and removed
ready-for-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.