Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uniswap V4 to dex.trades #7439

Closed
wants to merge 22 commits into from

Conversation

agaperste
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Testing uni v4 dex trades on eth sepolia, then will create for v4 on all deployed chains


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 8, 2025
@jeff-dude jeff-dude self-assigned this Jan 9, 2025
@jeff-dude
Copy link
Member

jeff-dude commented Jan 10, 2025

@Hosuke if you get a chance, can you take a look at this and push some commits to help get CI pass?

plz note the short-term workaround for row_number function and filter due to some testing from jackie and team, but will not be needed when we change to mainnet. here are some notes on this scenario and why it's in place for now:

why unique combo failed

  • there are two v4 core contracts (meaning 2 different addresses) being decoded under the same project name and contract name (so Uniswap_v4_sepolia.PoolManager...)
  • this happened because while there already existed a v4 core contract on sepolia, my coworker created another contract to help me with some other test data
  • but as a result it creates scenario where the same pool was created multiple times
  • hence when joining pool initiazation with swaps, sql creates duplicates
  • but in reality when v4 properly launches we will only have ONE v4 core contract deployed, so there will not be dupes

if you don't get a chance to look, it's all good, i will try to help tomorrow 🙏

@agaperste
Copy link
Contributor Author

Closing this test PR. Will raise real ones once v4 deploys to mainnets.

@agaperste agaperste closed this Jan 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants