-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timeswap dex to trades #7348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
work in progress
dbt: dex
covers the DEX dbt subproject
labels
Dec 17, 2024
github-actions
bot
added
ready-for-review
this PR development is complete, please review
and removed
WIP
work in progress
labels
Jan 20, 2025
Hosuke
reviewed
Jan 21, 2025
dbt_subprojects/dex/models/trades/optimism/dex_optimism_base_trades.sql
Outdated
Show resolved
Hide resolved
jeff-dude
added
in review
Assignee is currently reviewing the PR
and removed
ready-for-review
this PR development is complete, please review
labels
Jan 21, 2025
Hosuke
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @archie17277
Hosuke
added
ready-for-merging
and removed
in review
Assignee is currently reviewing the PR
labels
Jan 24, 2025
jeff-dude
approved these changes
Jan 24, 2025
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
Add
Timeswap_v2
dex onoptimism
chain.