Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI upgrade: list modified downstream #6997

Merged
merged 10 commits into from
Oct 24, 2024
Merged

CI upgrade: list modified downstream #6997

merged 10 commits into from
Oct 24, 2024

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Oct 23, 2024

CI upgrade:
This adds a step that prints the list of modified downstream models (adds about ~8sec in CI)

@0xRobin
Copy link
Collaborator Author

0xRobin commented Oct 23, 2024

@0xRobin 0xRobin marked this pull request as ready for review October 23, 2024 14:27
@0xRobin 0xRobin requested review from Hosuke and jeff-dude October 23, 2024 14:27
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great upgrade!

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

looks like it kicks off all CI jobs, due to modification to dbt_run.yml, but shouldn't trigger anything in prod if merged?

@0xRobin
Copy link
Collaborator Author

0xRobin commented Oct 23, 2024

looks like it kicks off all CI jobs, due to modification to dbt_run.yml, but shouldn't trigger anything in prod if merged?

exactly

@0xBoxer
Copy link
Collaborator

0xBoxer commented Oct 23, 2024

Due to a dbt version change, you need to merge main into your branch before the Github action runner runs successfully again.

@0xRobin 0xRobin merged commit 2279577 into main Oct 24, 2024
7 of 8 checks passed
@0xRobin 0xRobin deleted the list-modified-in-CI branch October 24, 2024 07:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dune team created by dune team ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants