Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sei to nft_transfers #6832

Merged
merged 14 commits into from
Oct 16, 2024
Merged

Add Sei to nft_transfers #6832

merged 14 commits into from
Oct 16, 2024

Conversation

peterrliem
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 11026410431 approved.

@dune-eng
Copy link

Workflow run id 11026410571 approved.

@dune-eng
Copy link

Workflow run id 11026428389 approved.

@dune-eng
Copy link

Workflow run id 11026428521 approved.

@dune-eng
Copy link

Workflow run id 11026541870 approved.

@dune-eng
Copy link

Workflow run id 11026541690 approved.

@dune-eng
Copy link

Workflow run id 11026616718 approved.

@dune-eng
Copy link

Workflow run id 11026616939 approved.

@dune-eng
Copy link

Workflow run id 11026702955 approved.

@dune-eng
Copy link

Workflow run id 11026702825 approved.

@dune-eng
Copy link

Workflow run id 11027013935 approved.

@dune-eng
Copy link

Workflow run id 11027014212 approved.

@jeff-dude jeff-dude added the WIP work in progress label Sep 25, 2024
@dune-eng
Copy link

Workflow run id 11045493627 approved.

@dune-eng
Copy link

Workflow run id 11045493687 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118765006 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118765230 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118873890 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118874074 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118875856 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11118875908 approved.

@peterrliem
Copy link
Contributor Author

@jeff-dude I think I'm overlooking a simple thing. can you point it out?

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11127874513 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11127875285 approved.

@jeff-dude
Copy link
Member

sorry meant {{ not {(

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11130102488 approved.

@dune-eng
Copy link

dune-eng commented Oct 1, 2024

Workflow run id 11130102704 approved.

@0xRobin 0xRobin self-assigned this Oct 14, 2024
@jeff-dude
Copy link
Member

the test timeout on nft transfers is a common issue in CI these days. i wonder if it's due to inefficient default query in dbt built tests?

@0xRobin
Copy link
Collaborator

0xRobin commented Oct 15, 2024

yeah the unique_id check is very compute heavy on the big model (because every row is unique)
I'll add a filter to this for the top level nft.transfers so we only run it on the last week.

@0xRobin 0xRobin added ready-for-merging dbt: nft covers the NFT dbt subproject and removed WIP work in progress labels Oct 15, 2024
@jeff-dude jeff-dude merged commit e24e01d into duneanalytics:main Oct 16, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants