fix 1inch trade pair #6236
Closed
fix 1inch trade pair #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow run id 9618842469 approved. |
|
Workflow run id 9618842880 approved. |
|
Workflow run id 9618842865 approved. |
aalan3
reviewed
Jun 26, 2024
| @@ -19,7 +19,10 @@ select | |||
| , block_number | |||
| , coalesce(dst_token_symbol, '') as token_bought_symbol | |||
| , coalesce(src_token_symbol, '') as token_sold_symbol | |||
| , array_join(array_sort(array[coalesce(src_token_symbol, ''), coalesce(dst_token_symbol, '')]), '-') as token_pair | |||
| , case | |||
There was a problem hiding this comment.
@grkhr does this look good to you?
There was a problem hiding this comment.
as mentioned in the PR I just applied the same logic as in DEX trades. It seems the current logic doesn't work well with mixed-case token symbols - see example: https://dune.com/queries/3864620
|
will be fixed here with other spells #6285 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For bug fixes
If you are fixing a bug, please provide the following information:
trade_pairwith symbols incorrectly sorted.dex.tradesspells.Thank you for your contribution!