Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bebop infinity values #6228

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Fix Bebop infinity values #6228

merged 5 commits into from
Jun 25, 2024

Conversation

B1boid
Copy link
Contributor

@B1boid B1boid commented Jun 21, 2024

Bug fix:
When there was no price for asset, division by zero leaded to 'Infinity' amount_usd values
Also fixed duplicates in bebop_blend_ethereum.trades

@dune-eng
Copy link

Workflow run id 9612541417 approved.

@dune-eng
Copy link

Workflow run id 9612541491 approved.

@dune-eng
Copy link

Workflow run id 9612541495 approved.

@dune-eng
Copy link

Workflow run id 9612933483 approved.

@dune-eng
Copy link

Workflow run id 9612933716 approved.

@dune-eng
Copy link

Workflow run id 9612933729 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @B1boid

@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR and removed ready-for-final-review labels Jun 24, 2024
@dune-eng
Copy link

Workflow run id 9661586064 approved.

@dune-eng
Copy link

Workflow run id 9661586226 approved.

@dune-eng
Copy link

Workflow run id 9661586233 approved.

@dune-eng
Copy link

Workflow run id 9661734070 approved.

@dune-eng
Copy link

Workflow run id 9661734275 approved.

@dune-eng
Copy link

Workflow run id 9661734273 approved.

@dune-eng
Copy link

Workflow run id 9662092566 approved.

@dune-eng
Copy link

Workflow run id 9662092747 approved.

@dune-eng
Copy link

Workflow run id 9662092738 approved.

@dune-eng
Copy link

Workflow run id 9662438703 approved.

@dune-eng
Copy link

Workflow run id 9662438873 approved.

@dune-eng
Copy link

Workflow run id 9662438911 approved.

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress in review Assignee is currently reviewing the PR labels Jun 25, 2024
@jeff-dude jeff-dude merged commit 19fb541 into duneanalytics:main Jun 25, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants