interim integration of paraswap v6.2: replace old v6.1 for now #6198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking at CI results prior to looking at code -- looks like a source table doesn't exist? are we still waiting on it to be created? |
code looks good otherwise. just gotta look at these: |
|
@jeff-dude indeed contracts were added after creating PR, which I now realize was an oversight. Does that mean we're good to merge? |
aalan3
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of the PR is to update Paraswap v6 models to refer to the new v6.2 contract.
It is planned for later to adjust the configuration to make the models include both v6.1 and v6.2.