Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add account_type column to token_accounts solana #6110

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

andrewhong5297
Copy link
Collaborator

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

@aalan3 mentioned it would be good if added an account type column to token_accounts, so we can filter on the heavy JOINs. I'm adding it here.

@jeff-dude jeff-dude added the WIP work in progress label Jun 11, 2024
@andrewhong5297
Copy link
Collaborator Author

@aalan3 @jeff-dude this should be merged next, so we can add a nft filter out for all the dex trades spells. this will shrink the join by a ton.

@jeff-dude
Copy link
Member

@aalan3 @jeff-dude this should be merged next, so we can add a nft filter out for all the dex trades spells. this will shrink the join by a ton.

noted. we can likely work on this soon as we wrap up some of the other subprojects early this week. we'll also be having a discussion tomorrow on where solana spells live.

@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 17, 2024
Copy link
Contributor

@aalan3 aalan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged after #6197. This might trigger a bunch of full refreshes btw but we can skip those since we are just adding a column here.

@aalan3 aalan3 added ready-for-merging blocked and removed ready-for-review this PR development is complete, please review labels Jun 18, 2024
@aalan3 aalan3 force-pushed the tokenaccountcat branch from 7f25db5 to e316f74 Compare June 20, 2024 10:36
@aalan3 aalan3 merged commit 3fc938d into main Jun 20, 2024
1 of 2 checks passed
@aalan3 aalan3 deleted the tokenaccountcat branch June 20, 2024 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants