Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur & Fantasy trades #6091

Merged
merged 15 commits into from
Jun 11, 2024
Merged

Blur & Fantasy trades #6091

merged 15 commits into from
Jun 11, 2024

Conversation

hildobby
Copy link
Collaborator

@hildobby hildobby commented Jun 5, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@hildobby hildobby added WIP work in progress dbt: nft covers the NFT dbt subproject labels Jun 5, 2024
@hildobby hildobby requested a review from 0xRobin June 5, 2024 13:52
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but will hold of on merging as we're in the middle of moving the NFT lineage to it's own subproject. (#6090)

@0xRobin 0xRobin added blocked ready-for-final-review and removed WIP work in progress labels Jun 6, 2024
@hildobby
Copy link
Collaborator Author

hildobby commented Jun 6, 2024

approving, but will hold of on merging as we're in the middle of moving the NFT lineage to it's own subproject. (#6090)

ah alright, then i'll also add blur on blast in here in the meantime. any chance of it getting merged by the time blast is announced to be on dune? because that's what i told the teams 😬

@hildobby hildobby changed the title Fantasy trades Blur & Fantasy trades Jun 6, 2024
@0xRobin 0xRobin mentioned this pull request Jun 7, 2024
@jeff-dude
Copy link
Member

@aalan3 recommended proceeding here, then rebase other PR which moves the spells

@jeff-dude jeff-dude merged commit 8d4db5e into duneanalytics:main Jun 11, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants