Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trusted_tokens #6068

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Jun 4, 2024

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@Hosuke Hosuke marked this pull request as ready for review June 5, 2024 16:05
@Hosuke Hosuke added the ready-for-review this PR development is complete, please review label Jun 5, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jun 5, 2024

Major update in this PR:
add [linea, scroll, zkevm] trusted tokens.

@jeff-dude
Copy link
Member

what's our plan for:

  • adding mantle to prices spell lineage?
  • adding mantle to manual erc20 token lineage?
  • adding mantle to this trusted tokens list?

@jeff-dude jeff-dude self-assigned this Jun 5, 2024
@jeff-dude jeff-dude added question Further information is requested in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jun 5, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jun 7, 2024

what's our plan for:

  • adding mantle to prices spell lineage?
  • adding mantle to manual erc20 token lineage?
  • adding mantle to this trusted tokens list?

Thinking...
At least I know these may be the trusted tokens:
https://mantlescan.xyz/tokens

(Edit)
I write a query here:
https://dune.com/queries/3807309

This may initial the mantle prices feed list manually (holders > 10).
I may draft this in another PR.

(Second edit)
The PR is here #6112
After manually checking, a lot of tokens are fake tokens.
I will add those authentic to trusted tokens then.

@Hosuke
Copy link
Collaborator Author

Hosuke commented Jun 7, 2024

Added mantle trusted tokens in this PR.

@Hosuke Hosuke removed the question Further information is requested label Jun 7, 2024
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jun 11, 2024
@jeff-dude jeff-dude merged commit e653942 into duneanalytics:main Jun 11, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants