Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init dex_mantle_base_trades #6058

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Jun 3, 2024

Trying to add dex_mantle.base_trades

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@Hosuke Hosuke added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jun 3, 2024
@jeff-dude
Copy link
Member

for tracking and conversation tomorrow:

Dexes Mantle would like to add to DEX trades:

  • Agni (to be added - there was an issue with the contract)
  • Butter
  • fusionx
  • merchant moe
  • Izumi

Agni, FusionX, and Butter are all forks of either Uniswap v2 or v3. except that Merchant Moe is Trader Joe v2 fork. FYI: https://defillama.com/protocol/merchant-moe-liquidity-book#information.

@jeff-dude
Copy link
Member

we should also add to trusted tokens, then maybe have a separate PR to add other recent chains to keep it up-to-date

@jeff-dude jeff-dude self-assigned this Jun 3, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jul 18, 2024

Sample merchant_moe_mantle_base_trades:
https://dune.com/queries/3926315

@Hosuke Hosuke marked this pull request as ready for review July 18, 2024 14:57
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed WIP work in progress blocked labels Jul 18, 2024
@jeff-dude
Copy link
Member

jeff-dude commented Jul 18, 2024

did we ever add trusted tokens prices for mantle?

then the other DEXs expected for mantle (all supposed to be uniswap v2 or v3 forks):

  • agni
  • fusionX
  • butter

from what i see in data explorer, we have event decoded tables for the pools created, but we don't have swap events for any of these. do you agree?

@jeff-dude jeff-dude added the question Further information is requested label Jul 18, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jul 20, 2024

from what i see in data explorer, we have event decoded tables for the pools created, but we don't have swap events for any of these. do you agree?

  • agni
    -- missing in the decoded project list.
  • fusionX
    -- missing general Pair_evt_swap decoding
  • butter
    -- missing general Pair_evt_swap decoding

Also mantle trusted tokens have been added here:
https://github.com/duneanalytics/spellbook/blob/main/models/prices/prices_trusted_tokens.sql#L77

@Hosuke Hosuke removed the question Further information is requested label Jul 20, 2024
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jul 22, 2024
@jeff-dude jeff-dude merged commit 2eb0214 into duneanalytics:main Jul 23, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants