Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT dbt subproject #6090

Merged
merged 20 commits into from
Jun 14, 2024
Merged

NFT dbt subproject #6090

merged 20 commits into from
Jun 14, 2024

Conversation

0xRobin
Copy link
Collaborator

@0xRobin 0xRobin commented Jun 5, 2024

This splits of the NFT models in it's own dbt subproject.

worth mentioning that I've placed the generic tests that are used cross projects into their macro file. This way they are accessible by all (check_seed, check_columns etc)

@0xRobin 0xRobin force-pushed the dbt-subproject-nft branch from 02ae80a to 129df80 Compare June 5, 2024 13:14
@0xRobin 0xRobin mentioned this pull request Jun 6, 2024
3 tasks
@0xRobin 0xRobin added ready-for-review this PR development is complete, please review dune team created by dune team dbt: nft covers the NFT dbt subproject labels Jun 6, 2024
@0xRobin 0xRobin requested review from jeff-dude and aalan3 June 6, 2024 12:17
@0xRobin
Copy link
Collaborator Author

0xRobin commented Jun 7, 2024

@aalan3 @jeff-dude, this should be good to merge when you've set up the production side for the NFT subproject.

These PRs will need to be adapted to the new location and can then also proceed:

@aalan3
Copy link
Contributor

aalan3 commented Jun 7, 2024

@0xRobin amazing work thank you! I'll setup a new hourly cluster and then merge this. Might not get to it today due to Solana merges.

@aalan3 aalan3 force-pushed the dbt-subproject-nft branch from 3764d0e to 2041b9b Compare June 14, 2024 07:45
Copy link
Contributor

@aalan3 aalan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aalan3 aalan3 merged commit 8aca70c into duneanalytics:main Jun 14, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject dune team created by dune team ready-for-review this PR development is complete, please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants