round related method support generics #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## rc #195 +/- ##
==========================================
+ Coverage 79.90% 79.94% +0.04%
==========================================
Files 65 65
Lines 7484 7484
==========================================
+ Hits 5980 5983 +3
+ Misses 1136 1135 -1
+ Partials 368 366 -2 ☔ View full report in Codecov by Sentry. |
duke-git
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range of supported types refers to Round[T SignedNumber | UnsignedNumber](val T) T
Regarding the TruncRound method, it fails the original test when x is the literal 0, which is a refactoring that breaks compatibility. However, I believe few people would do this.
Personally, I think it makes more intuitive sense for the parameter and return types to be consistent, while the semantics of the original function names are preserved for other functions.