Wip #510
Draft
Wip #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/pgduckdb/pgduckdb_guc.h # Conflicts: # src/scan/heap_reader.cpp # src/scan/postgres_seq_scan.cpp
Added WaitLatch that can be used with multiple threads in process.
At the very least SlotGetAllAttrs should should be called while holding the lock.
Y--
force-pushed
the
yl/native-scan-iter
branch
3 times, most recently
from
1df184d to
b9e1107
Compare
If GlobaclLock is held for duration of populating output vector we don't need any special WaitLatch wrappers and we can call directly this function.
We should now support all types with native postgres scan
Y--
force-pushed
the
yl/native-scan-iter
branch
from
324eeb0 to
3a5e38e
Compare
mkaruza
force-pushed
the
postgres-native-scan
branch
from
6a726f9 to
570f34f
Compare
JelteF
force-pushed
the
postgres-native-scan
branch
from
7b0685b to
e0135e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.