Feedbacks

README.md

@@ -169,6 +169,8 @@ INSERT INTO duckdb.secrets
 VALUES ('Azure', '<your connection string>');
 ```
 
+Note: writes to Azure are not yet supported, [here][duckdb/duckdb_azure#44] is the current discussion for more information.
+
 ### Connect with MotherDuck
 
 pg_duckdb also integrates with [MotherDuck][md]. To enable this support you first need to [generate an access token][md-access-token] and then add the following line to your `postgresql.conf` file:

include/pgduckdb/pgduckdb_options.hpp

@@ -35,8 +35,6 @@ typedef struct DuckdbSecret {
 	std::string connection_string; // Used for Azure
 } DuckdbSecret;
 
-bool DoesSecretRequiresKeyIdOrSecret(const SecretType type);
-
 std::string SecretTypeToString(SecretType type);
 
 extern std::vector<DuckdbSecret> ReadDuckdbSecrets();

sql/pg_duckdb--0.1.0--0.2.0.sql

@@ -84,7 +84,7 @@ ALTER TABLE duckdb.secrets ALTER COLUMN secret DROP NOT NULL;
 
 -- Update "type_constraint" CHECK on "type" to allow "Azure"
 ALTER TABLE duckdb.secrets DROP CONSTRAINT type_constraint;
-ALTER TABLE duckdb.secrets ADD CONSTRAINT type_constraint CHECK (type IN ('S3', 'GCS', 'R2', 'Azure'));
+ALTER TABLE duckdb.secrets ADD CONSTRAINT type_constraint CHECK (upper(type) IN ('S3', 'GCS', 'R2', 'AZURE'));
 
 -- Add "azure_connection_string" column
 ALTER TABLE duckdb.secrets ADD COLUMN connection_string TEXT;

src/pgduckdb_duckdb.cpp

@@ -258,12 +258,10 @@ DuckDBManager::LoadSecrets(duckdb::ClientContext &context) {
 		query << "CREATE SECRET pgduckb_secret_" << secret_id << " ";
 		query << "(TYPE " << SecretTypeToString(secret.type) << ", ";
 
-		if (DoesSecretRequiresKeyIdOrSecret(secret.type)) {
-			WriteSecretQueryForS3R2OrGCP(secret, query);
-		} else if (secret.type == SecretType::AZURE) {
+		if (secret.type == SecretType::AZURE) {
 			query << "CONNECTION_STRING '" << secret.connection_string << "'";
 		} else {
-			throw std::runtime_error("Invalid secret type: '" + std::to_string(secret.type) + "'");
+			WriteSecretQueryForS3R2OrGCP(secret, query);
 		}
 
 		query << ");";