Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the press reaction more visible #244

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

Borwe
Copy link
Contributor

@Borwe Borwe commented Oct 29, 2023

Scope

Please make sure to read the Contribution Guidelines
and check that you understand and have followed it as best as possible Explain what your feature
does in a short paragraph.
please check the below boxes

  • I have followed the coding conventions
  • I have added/updated necessary tests
  • I have tested the changes added on a physical device
  • I have run ./codeAnalysis.sh on linux/unix or codeAnalysys.bat on windows to make sure all lint/formatting checks have been done.

Closes/Fixes Issues

Clicking the bottom bar menu items had a wierd effect, of only highlighting icons, and not atleast most of the bottom menu options.

Other testing QA Notes

Pressing

a button on the bottombar looked kind of wierd, as the bottom text wasn't highlighted but the small picture only.

Please add a screenshot (if necessary)
Before
before

After
new

@Borwe
Copy link
Contributor Author

Borwe commented Oct 29, 2023

after

@Borwe
Copy link
Contributor Author

Borwe commented Oct 29, 2023

after2 Added padding to resemble old spacing.

@chepsi chepsi added this pull request to the merge queue Oct 30, 2023
Merged via the queue into droidconKE:main with commit 828d999 Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants