Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This code change allows you to use your own stream when recording audio. The StartRecording function now accepts a stream object:
public async Task<Task<string>> StartRecording (Stream recordStream = null, bool writeHeaders = false)
If
recordStream
isnull
the old behavior is used where a file is written on the device. The writeHeaders flag can be used to write the WAV headers to the beginning of the stream.Example usage:
var memoryStream = new MemoryStream();
var audioRecordTask = await recorder.StartRecording (memoryStream, true);
I added this change for my scenario where I don't want data to be stored on the device or use an internal memoryStream like NateRickard/Plugin.AudioRecorder#48.
This change will also allow scenarios mentioned in NateRickard/Plugin.AudioRecorder#12 and NateRickard/Plugin.AudioRecorder#13 by reusing the stream. It also supports the scenario of NateRickard/Plugin.AudioRecorder#48, using a memory stream instead of filestream.