Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -e to set env variables #45844

Open
wants to merge 2 commits into
base: release/9.0.2xx
Choose a base branch
from
Open

Use -e to set env variables #45844

wants to merge 2 commits into from

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 9, 2025 •
edited
Loading

Use new -e dotnet-run option instead of env directives. Allows to remove workarounds for #40484 and override env variables set by launch profile as required by Aspire spec.

Also use new option --no-launch-profile-arguments to ignore launch profile command line arguments when requested by DCP.

Implements #43946

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 9, 2025
@tmat tmat marked this pull request as ready for review January 9, 2025 23:21
@tmat tmat requested a review from a team as a code owner January 9, 2025 23:21
@tmat
Copy link
Member Author

tmat commented Jan 9, 2025

@karolz-ms @phil-allen-msft ptal

karolz-ms
karolz-ms approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@tmat tmat enabled auto-merge (squash) January 9, 2025 23:59
This was referenced Jan 10, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @karolz-ms @phil-allen-msft