Add fast path to String.Equals #111806
Draft
Add fast path to String.Equals #111806
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
xtqqczze
reviewed
Jan 24, 2025
This was referenced Jan 24, 2025
This was referenced Jan 25, 2025
EgorBo
added
area-System.Runtime
and removed
needs-area-label
EgorBo
force-pushed
the
test-optimization
branch
from
18264c1 to
948b8d7
Compare
This was referenced Jan 25, 2025
Open
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiments with #111586 (comment)
Currently, our primary method for comparing strings is
SpanHelpers.SequenceEqual. Due to the string's object layout, we always provideSequenceEqualwith only 4-byte aligned data (the offset of String._firstChar is 12 bytes), which might negatively impact performance.SequenceEqualcurrently does not align data, meaning its Vector512 path always hits the cache line every iteration.Also, do 64b/16b alignment inside SequenceEqual itself
We will see what the performance bot thinks about the microbenchmarks 🙂