Disable LTCG for brotli and zlibng. #111805
Open
+5
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclusively use CMake's INTERPROCEDURAL_OPTIMIZATION settings to handle turning on/off LTCG on Windows. By consistently using these settings, we can be sure that we're not building anything for NativeAOT with /LTCG or /GL.
3 tasks
jkotas
reviewed
Jan 24, 2025
| @@ -30,3 +30,4 @@ target_compile_definitions(brotlicommon PRIVATE BROTLI_SHARED_COMPILATION BROTLI | |||
| # Don't build the brotli command line tool unless explicitly requested | |||
| # (which we never do) | |||
| set_target_properties(brotli PROPERTIES EXCLUDE_FROM_ALL ON) | |||
| set_property(TARGET brotlienc brotlidec brotlicommon PROPERTY INTERPROCEDURAL_OPTIMIZATION OFF) | |||
There was a problem hiding this comment.
Is this going to disable LTCG for regular Brotli build that ships in System.Compression.Native as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclusively use CMake's INTERPROCEDURAL_OPTIMIZATION settings to handle turning on/off LTCG on Windows.
By consistently using these settings, we can be sure that we're not building anything for NativeAOT with /LTCG or /GL.
Fixes #111566