[DRAFT] Cached interface dispatch for coreclr #111771
Draft
+1,827
−459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on shared things, and parts that are not shared
…an be switched between
… not yet supported
…ce dispatch or virtual stub dispatch
|
Tagging subscribers to this area: @mangod9 |
Open
3 tasks
…te that this requires adding the -mcx16 switch to clang, so that cmpxchg16b instruction gets generated, which is an increase in the baseline CPU required by CoreCLR on Linux, and isn't likely to be OK for shipping publicly
…veAOT cached interface dispatch implementation (as it isn't actually used) Update IsIPinVirtualStub to check the AVLocations, not the stub entry points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards enabling cached interface dispatch for CoreCLR (should reduce memory usage/remove RWX pages, at the cost of reducing performance)
This is a test PR of in progress work, to see what is working
Known issues that need to be addressed before making a non-draft PR
[ ] Env flag for swapping between cached interface dispatch and VSD when both features are enabled in the code
[ ] Testing of normal scenarios
[ ] Testing of diagnostic scenarios
[ ] Consider enabling the resolve cache for cached interface dispatch scenarios
[ ] Enable support for R2R with cached interface dispatch
[ ] Make the Indirection cell size 2 pointers instead of 4
[ ] Free dispatch cache infrastructure on collectible assembly destruction
[ ] Move
PalInterlockedCompareExchange128to the PAL or minipal[ ] Actually correct construction of indirection cell for virtual dispatch on vtables