Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matched check for balancing groups in regex compiler / source generator #111769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix matched check for balancing groups in regex compiler / source generator #111769

wants to merge 1 commit into from
+16 −22

Conversation

stephentoub
Copy link
Member

The emitted IsMatched check should come after processing the child, not before.

Fixes #111630
Fixes #111631

@stephentoub
Fix matched check for balancing groups in regex compiler / source gen…
e4089c1 
…erator

The emitted IsMatched check should come after processing the child, not before.
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

This was referenced Jan 23, 2025
Open
Open
@stephentoub stephentoub requested a review from joperezr January 25, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmoseley danmoseley Awaiting requested review from danmoseley

@joperezr joperezr Awaiting requested review from joperezr

At least 1 approving review is required to merge this pull request.

Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions
Projects
None yet
Milestone
No milestone
1 participant
@stephentoub