Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brotli native code is compiled with LTCG #111566

Open
MichalStrehovsky opened this issue Jan 18, 2025 · 5 comments · May be fixed by #111805
Open

Brotli native code is compiled with LTCG #111566

MichalStrehovsky opened this issue Jan 18, 2025 · 5 comments · May be fixed by #111805
Assignees
@jkoritzinsky
Labels
area-NativeAOT-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@MichalStrehovsky
Copy link
Member

And this is going to break everyone who doesn't use exactly the same version of VC++ as we used on the build machine.

Reported at aspnet/Benchmarks#2047. We should also check zlib.

  brotlienc.lib(encode.c.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
EXEC : fatal error C1900: Il mismatch between 'P1' version '20240319' and 'P2' version '20220715' [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6848\ooktqbfk.xuf\src\Benchmarks\Benchmarks.csproj]
LINK : fatal error LNK1257: code generation failed [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6848\ooktqbfk.xuf\src\Benchmarks\Benchmarks.csproj]
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 18, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky MichalStrehovsky mentioned this issue Jan 18, 2025
Open
@jkotas
Copy link
Member

jkotas commented Jan 18, 2025

cc @jkoritzinsky Regression introduced by #109707 ?

@jkoritzinsky
Copy link
Member

Yes this was introduced by #109707.

@jkoritzinsky jkoritzinsky self-assigned this Jan 18, 2025
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Jan 21, 2025
@MichalStrehovsky
Fail tests if LTCG is used
f4b0dd9 
dotnet#111566 is not the first time we accidentally shipped something built with LTCG. We should ideally not allow merging such code into `main`.
@MichalStrehovsky MichalStrehovsky mentioned this issue Jan 21, 2025
Open
@MichalStrehovsky
Copy link
Member Author

@jkoritzinsky will you have time to look at this soon-ish? If we're unlucky and VC++ ships an update at the same time we ship preview 1, this could mean that native AOT in Preview 1 won't be usable since most people will have a VC++ compiler that is not compatible with what we built.

@jkoritzinsky
Copy link
Member

I put out a fix in #111805

@jkoritzinsky jkoritzinsky linked a pull request Jan 24, 2025 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jan 24, 2025
@agocke agocke added this to the 10.0.0 milestone Jan 25, 2025
@agocke agocke removed the untriaged New issue has not been triaged by the area owner label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkoritzinsky jkoritzinsky

Labels
area-NativeAOT-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
AppModel
Status: No status
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Disable LTCG for brotli and zlibng. jkoritzinsky/runtime
4 participants
@agocke @jkoritzinsky @jkotas @MichalStrehovsky