Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v121.0.1 #37

Merged
merged 26 commits into from
Jan 10, 2024
Merged

v121.0.1 #37

merged 26 commits into from
Jan 10, 2024

Conversation

dothq-robot
Copy link

Firefox v121.0.1

Merge in changes from upstream (v121.0.1)

Checklist

  • Changes have been reviewed
  • If necessary, any changes downstream (dothq/browser-desktop) have been made
  • Upstream with Dot Browser mounted can be built
  • REVISION file is ready to be updated

julian-seward1 and others added 26 commits December 15, 2023 17:37
…typeDef_ from signed 48-bit to unsigned 48-bit. r=yury, a=RyanVM

Bug 1861973 tried to clean up signedness issues relating to
js::wasm::PackedTypeCode::typeDef_ on 32 bit targets.  As a side effect, on 64
bit targets, it caused that field to be regarded as a 48-bit signed field,
rather than a 48-bit unsigned field.

That causes failures on 64-bit targets when handling TypeDef* values whose bit
47 is 1, since these get sign-extended back to the wrong value in
TypeDef::typeDef().

This fix reverts that part of the bug 1861973 patch, changing the
interpretation on 64-bit targets back to unsigned 48-bits, while leaving the
behaviour on 32-bit targets unchanged.  It has been tested on real hardware
for {x86_32, x86_64, arm32, arm64}-linux.

Differential Revision: https://phabricator.services.mozilla.com/D196563
…croTaskQueue r=arai a=RyanVM

I have yet to be able to produce an automated test for things under the control of
nsAutoSyncOperation; this patch has been verified locally using the following STR,
modified from [1].

STR for Mac

 1. Go to https://debugger-crash-before-print.glitch.me/
 2. Open debugger
 3. Press Command + P to trigger print for the page (This should cause the debugger to pause on line 2)
 4. Go to the console, and enter Promise.resolve(10).then(() => {}).
 5. Resume execution and cancel the print preview.
 5. Tab Crashes

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1849675#c3

Differential Revision: https://phabricator.services.mozilla.com/D195900
…, a=RyanVM

This gives us twice as many restarts on Android which will
hopefully reduce the incidence of S22 flicker (bug 1866555)

We've been running at the higher count on Nightly without issue
so this should be very low risk.

Differential Revision: https://phabricator.services.mozilla.com/D196604
…g,webrtc-reviewers, a=RyanVM

Cherry-picks abseil/abseil-cpp#1553

We should uplift this to beta and release.

Differential Revision: https://phabricator.services.mozilla.com/D197102
…ve menu bars for modals. r=mac-reviewers,bradwerth, a=RyanVM

Differential Revision: https://phabricator.services.mozilla.com/D197197
…a=RyanVM

Pixel 6, 7, and 8 devices running Android 14 are affected by a bug
where video frames with SMPTE 432 color primaries are rendered
incorrectly when sampled from an external texture in GLES. To work
around this, we force these frames to be converted to RGB using BT709
colorspace instead. While this won't look exactly right, it is much
better than the current situation.

When we detect that a frame is decoded with that color space on an
affected device, we set a "ForceBT709" flag which gets passed through
to webrender as a new ImageBufferKind. Rendering this ImageBufferKind
is handled via a new shader feature TEXTURE_EXTERNAL_BT709, which
works much like the existing TEXTURE_EXTERNAL feature, but
additionally uses the EXT_YUV_TARGET extension to override the
colorspace transformation.

This approach could be extended in the future to handle additional
colorspace transformations, but for now only handles the one required
to workaround this particular driver bug.

Original Revision: https://phabricator.services.mozilla.com/D195800

Differential Revision: https://phabricator.services.mozilla.com/D197049
…s without image_external_essl3. a=RyanVM

An oversight when updating the allowed shaders list in bug 1866020
assumed that devices without GL_OES_EGL_image_external_essl3 would
also not have GL_EXT_YUV_target. This turns out not to always be the
case, and results in a crash when attempting to initialize the shaders
on such devices.

This patch checks explicitly for GL_EXT_YUV_target when generating the
allowed shaders list.

Original Revision: https://phabricator.services.mozilla.com/D196716

Differential Revision: https://phabricator.services.mozilla.com/D197050
…ached. r=taskgraph-reviewers,kshampur,jcristau a=release

They are triggered via cron, so an empty run-on-projects should be the
appropriate config.

As they are not idempotent (they will pick the last from upstream on
each run), they also shouldn't be cached.

Differential Revision: https://phabricator.services.mozilla.com/D197303
… is in January causing perma test failures r=jsudiaman,fxview-reviewers a=test-only
…ne-wrapping regressions. a=RyanVM

This reverts the change to make ideographic space trimmable, because of unintended impact on line
breaking and measurement in other cases. We'll need a more carefully targeted fix for the original
issue in bug 1862249, as well as better test coverage when landing a new patch there.

(Given that we've had multiple regression reports about this, I think we should uplift the backout
to 122. We could even consider it for a 121.x dot-release if one happens, as it's just reverting
to longstanding behavior here.)

Original Revision: https://phabricator.services.mozilla.com/D197150

Differential Revision: https://phabricator.services.mozilla.com/D197545
…ow. a=RyanVM

The bug occurs because some abspos children are split, but not being reflowed
again in the last column balancing reflow where the available block-size of the
last column might be unconstrained.

This patch makes the callers utilizing `ReflowInput::ShouldReflowAllKids()`
always reflow in the last column balancing reflow to ensure the correctness of
the layout.

Note: the `mIsInLastColumnBalancingReflow` flag is inheriting from parent to
child reflow input, but it will stop at the nested `nsColumnSetFrame` because
the nested one will create its own `ReflowConfig::mIsLastBalancingReflow` and
assign that flag when creating the reflow input for the children.

Original Revision: https://phabricator.services.mozilla.com/D195945

Differential Revision: https://phabricator.services.mozilla.com/D196092
…ing Product. a=RyanVM

- Fixes regression of allowing validations to fail by passing `allowValidationFailure` in `ShoppingProduct.request` options.
- Adds tests to make sure that validations are allowed to fail.

Original Revision: https://phabricator.services.mozilla.com/D196907

Differential Revision: https://phabricator.services.mozilla.com/D197082
…X_121_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
…X_121_0_1_RELEASE a=release CLOSED TREE DONTBUILD
@kierandrewett kierandrewett merged commit d154bdc into dothq:release Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.